filter out title execArgv to workers #8719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpolun
commented
Dec 27, 2022
| let hasArgWithParam = | ||
| ((arg === '-r' || arg === '--require') && | ||
| filteredArgs[i + 1] === '@parcel/register') || | ||
| arg === '--title'; |
There was a problem hiding this comment.
I can make this into a regex (like the single args filtered above) if you'd prefer. It's kind of pointless when there's only one, but I could do it for consistency.
maxpolun
commented
Dec 27, 2022
mischnic
reviewed
Dec 28, 2022
Co-authored-by: Niklas Mischkulnig <[email protected]>
mischnic
approved these changes
Dec 28, 2022
marcins
pushed a commit
to marcins/parcel
that referenced
this pull request
Jul 14, 2023
* upstream/v2: (33 commits) v2.8.3 Changelog for v2.8.3 Address bug by updating an asset reference and merge conditions (parcel-bundler#8762) Fix CSS order when merging type change bundles (parcel-bundler#8766) fixing failing build for contributors on Linux using Node 18 (parcel-bundler#8763) Extension: Importers View and separate LSP protocol package (parcel-bundler#8747) Bump swc to fix sourcemaps with Windows line endings (parcel-bundler#8756) Apply HMR updates in topological order (parcel-bundler#8752) Make extension packaging work (parcel-bundler#8730) Typed api.storeResult (parcel-bundler#8732) Refactor LSP to use vscode-jsonrpc (parcel-bundler#8728) Bump swc (parcel-bundler#8742) Recursively check reachability when removing asset graphs from bundles in deduplication (parcel-bundler#6004) Fix tsc sourcemaps metadata (parcel-bundler#8734) Assigning to `this` in CommonJS (parcel-bundler#8737) Don't retarget dependencies if a symbol is imported multiple times with different local names (parcel-bundler#8738) Add a note about using flow in CONTRIBUTING.md (parcel-bundler#8731) filter out title execArgv to workers (parcel-bundler#8719) Document more of the BundleGraph class (parcel-bundler#8711) Fixed the hmr connection with host 0.0.0.0 (parcel-bundler#7357) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
As I reported in #8673 parcel will crash when a
--title [process name]is passed to node and worker threads are being used. This PR filters that arg out so that parcel will not crash.💻 Examples
--title [process name]sets the name of the process (so it makes sense why threads can't take this arg). It can be set by some tools. I noticed it while using moon.🚨 Test instructions
There don't seem to be unit tests for the other filtered args, so I didn't add any here, but it's easy to test manually, just run
node --title test /path/to/parcel index.html✔️ PR Todo