Make ts-types transformer work with TS >= 4.8 #8661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
mischnic
force-pushed
the
ts-types-updates
branch
from
61e01e9
to
918a28c
Compare
lettertwo
added a commit
that referenced
this pull request
Dec 8, 2022
* upstream/v2: Make sure we're compiling on ubuntu-20.04 v2.8.1 Add mjs and cjs to resolver extensions (#8667) Fix transformer-svg-react not finding .svgrrc's (#7741) Fix overriding single export of a `export *` (#8653) chore: spelling fix (#8614) Parse shortcut icons in web app manifests (#8660) Make ts-types transformer work with TS >= 4.8 (#8661) Don't retarget dependencies with `*` (#8645) fix: remove @parcel/utils dep in @parcel/graph (#8630)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8419
Just moving to the new AST functions fixed everything I can reproduce (so not sure about #8494), so the deprecation warnings and
Unhandled SyntaxKind: ImportClauseAPI Changes:
context.factory.(create|update)*instead ofts.(create|update)*isTypeOnlyparameters and nodecoratorsparameters anymore.getMutableCloneis deprecatedI've written a script to generate wrappers for the changing parameter orderings: https://github.com/mischnic/tsc-version-wrapper which was used for packages/transformers/typescript-types/src/wrappers.js. The integration tests pass with 4.0.0 (going even further makes Typescript complain about some library typings)
Problems:
node = ts.getMutableClone(node);line didn't break any tests, so I'm not sure why it was needed in the first place. Might be related to prevent TS from removing unused imports.