Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sharp #8568

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Upgrade sharp #8568

merged 1 commit into from
Oct 24, 2022

Conversation

mischnic
Copy link
Member

Closes #7738

The 0.29.* line is almost 1 year old now. But I'm not aware of any concrete problems with the old versions either...

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.48s -4.00ms
Cached 334.00ms -9.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 6.80s -90.00ms
Cached 300.00ms -1.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit a5fb028 into v2 Oct 24, 2022
@devongovett devongovett deleted the upgrade-sharp branch October 24, 2022 03:38
@revett
Copy link

revett commented Oct 24, 2022

Thanks @mischnic 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to sharp 0.30.x
4 participants