Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verbose warning: reexport all doesn't include default #8451

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Sep 7, 2022

Fixes some verbose warnings that were false positives such as:
@parcel/core: node_modules/ky-universal/browser.js reexports "default", which could be resolved either to the dependency "ky" or "ky" at runtime. Adding a namespace object to fall back on.

Test case (but not added because the symbol data is identical and asserting log messages is hard)

// index.js
import a from "./a.js";
console.log(a);

// a.js
export { default } from "./b.js";
export * from "./b.js";

// b.js
export default "def";
export const b = "b";

@parcel-benchmark
Copy link

parcel-benchmark commented Sep 7, 2022

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.38s +5.00ms
Cached 310.00ms -3.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 6.45s +31.00ms
Cached 272.00ms -5.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 3678a9f into v2 Sep 12, 2022
@mischnic mischnic deleted the fix-verbose-symbol-warning branch September 12, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants