Add parallel step for running integration tests with experimental bundler on CI #8245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
thebriando
force-pushed
the
bdo/experimental-on-ci
branch
from
e9f410d
to
cbc3c06
Compare
devongovett
approved these changes
Jun 28, 2022
AGawrys
added a commit
that referenced
this pull request
Jun 30, 2022
* add ref edges whenever there are bundle edges * add edge from bundlegroups to bundles wip * * Get inline bundles in bundle group in HTML packager * Traverse each bundle instead of iterating each outbound node * Add edge between root and bundle * use and follow reference edges again * set env whenever we create bundles * Check to add parallel edges from all paths to an asset from a bundle * Always register referenced bundles before pruning when building bundle manifest * Add test for referenced roots in bundle manifest * Add reused sibling bundles to asyncBundleRootGraph * Add test case for asset that has both an async and sync import *stop at isolated bundles *initialize entry bundles with no ancestors *accept shared bundles extracted from workers * Remove unused async bundles if needed * Scope-hositing with new bundler: allow less duplication * Consider sibling availability before removing from ancestorAssets * Remove reachableBundles * Consider sibling availability before removing from ancestorAssets * Consider assets in siblings before duplicating * Don't consider any of parent's async bundles as sibling * remove eager bundle reuse and related lending code * implement parallel request limits * create all shared bundles first then remove later * Alter tests with mode production and correct assets with logic for splittable bundles * Skip unused dependencies in experimental bundler * Implement getBundleFromBundleRoot * Only add dependencies to CSS module JS, not CSS * Handle multiple assets on dependencies in reachability * ScopeHoistingPackager: Handle different wrapped ancestries in wrapping dfs * move reachable root creation earlier to prevent unnecessary async bundle * replace reachableroots with syncAssetsRequired and skip sync deps for entries later on * Revert "replace reachableroots with syncAssetsRequired and skip sync deps for entries later on" * Implement cleanup for internalized deps from entrys * skip assets for reachable if isolated or inline fix invariant * skip assets for reachable if isolated or inline fix invariant * Use bundleGroup instead of bundle root for determining needsStableName * remove asset references for deleted bundles + minor fixes * Filter out bundleroots from reacable if they are subgraphs, consider isIsolated * Add bundle.mainEntryAsset * ExperimentalBundler: merge bundleBehavior and needsStableName * don't remove bundles depended on by url * don't flatted bundle to bundlegroup edges * point config to default bundler, create type change bundle regardless them clean based on bundlegroups, add referencing bundle to stack when creating bundles instead of only parent or bundlegroup, add merge and delete bundles to clean all structures * extract shared bundles from inline bundles * Internalize all async bundle before placing assets into bundles, add internalized assets to share bundles from their source bundles * add assert bundles to test * Reverse merge asset insertion order to maintain dep order for css, remove addassetonexit, instead do upward dfs to determine bundlegroups for assets * Forked tests which rely on size calculation for shared bundles which is different across bundles and rename bundles steps without numbers * Addedge support to toposort, use edges to differentiate parallel and async relationships in bundleroot, share assets between paralllel dep bundleroots * Add support for multiple targets by bundling per entries per target * parallel request limits + test * Dont allow multiple bundles of entry type in entry bundlegroupsr * Add parallel step for running integration tests with experimental bundler (#8245) Co-authored-by: Gora Kong <[email protected]> Co-authored-by: Will Binns-Smith <[email protected]> Co-authored-by: Eric Eldredge <[email protected]> Co-authored-by: thebriando <[email protected]> Co-authored-by: Niklas Mischkulnig <[email protected]> Co-authored-by: Devon Govett <[email protected]> Co-authored-by: Gora Kong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This adds a step in the workflow to run the integration tests with the experimental bundler. They are not required to pass for merging.
💻 Examples
🚨 Test instructions
✔️ PR Todo