Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swc and prevent pure comment removal #7833

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Bump swc and prevent pure comment removal #7833

merged 3 commits into from
Mar 18, 2022

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Mar 16, 2022

To use swc-project/swc#3115
Closes #7481

Closes #7755

@height
Copy link

height bot commented Mar 16, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Mar 16, 2022

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 9.08s +172.00ms
Cached 445.00ms +1.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 4.71s +584.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 57.65s -688.00ms
Cached 1.36s -40.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/editorView.5940e8e4.js 594.77kb +0.00b 42.39s +10.56s ⚠️
dist/popup.2d44a067.js 209.53kb +0.00b 42.39s +10.56s ⚠️
dist/Toolbar.2851c4b3.js 107.26kb +0.00b 42.39s +10.56s ⚠️
dist/Modal.ec0ec3f8.js 45.33kb +0.00b 42.39s +10.56s ⚠️
dist/ui.39c61c40.js 14.94kb +0.00b 42.39s +10.56s ⚠️
dist/smartMediaEditor.27b49d9d.js 13.25kb +0.00b 42.39s +10.56s ⚠️
dist/dropzone.0d17e26c.js 12.16kb +0.00b 42.39s +10.56s ⚠️
dist/EmojiPickerComponent.8fb3dd15.js 3.73kb +0.00b 42.39s +10.56s ⚠️
dist/dropzone.d03df26a.js 3.29kb +0.00b 42.39s +10.56s ⚠️
dist/clipboard.7ceac12b.js 2.93kb +0.00b 42.39s +10.56s ⚠️
dist/ResourcedEmojiComponent.9106318a.js 2.12kb +0.00b 42.39s +10.56s ⚠️
dist/browser.d28fd36c.js 1.69kb +0.00b 42.39s +10.56s ⚠️
dist/media-card-analytics-error-boundary.bead5bf1.js 1.12kb +0.00b 42.39s +10.56s ⚠️
dist/media-picker-analytics-error-boundary.3df18700.js 966.00b +0.00b 42.39s +10.56s ⚠️
dist/simpleHasher.a4c0be3d.js 643.00b +0.00b 42.39s +10.56s ⚠️

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.24s +39.00ms
Cached 263.00ms +4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 3e893b6 into v2 Mar 18, 2022
@mischnic mischnic deleted the swc-fix-pure branch March 18, 2022 08:16
gorakong pushed a commit that referenced this pull request Nov 3, 2022
* upstream/v2:
  Upgrade Flow to 0.174.1 (#7849)
  v2.4.0
  v2.4.0 changelog
  Bump Parcel CSS
  Dynamic imports priority fix closes #6980 (#7061)
  fix(transformers): errors.map is not a function (#7672)
  Make NodeResolver check realpath before resolving with `source` entry (#7846)
  docs: fix wrong location documents (#7689)
  Fix: escape double quote of url value in CSS `url()` (#7718)
  Update @parcel/css and add diagnostic for url dependencies in custom properties (#7845)
  Use relative path for bundle labels in bundle analysis (#7737)
  Allow use react-jsx transform in React 16.14.0 (#7728)
  Move to @parcel/css by default (#7821)
  Feature: pick PORT number also from .env file (#7819)
  Enable parsing static initialization blocks (#7839)
  Bump swc and prevent pure comment removal (#7833)
  Bump swc (#7777)
  Human readable file size in bundle analyzer report (#7766)
  Improve emoji support detection (#7775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants