More experimental bundler fixes #7783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Traverse each bundle instead of iterating each outbound node * Add edge between root and bundle
This reverts commit 73ad828.
|
Benchmark ResultsKitchen Sink 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
gorakong
reviewed
Mar 3, 2022
wbinnssmith
force-pushed
the
more-experimental-bundler-fixes
branch
from
22df351
to
a5d9610
Compare
wbinnssmith
reviewed
Mar 10, 2022
| @@ -5008,7 +5008,11 @@ describe('scope hoisting', function () { | |||
| ], | |||
| }, | |||
| {assets: ['dep.js']}, | |||
| {assets: ['async-has-dep.js', 'dep.js', 'get-dep.js']}, | |||
| { | |||
| assets: process.env.PARCEL_TEST_EXPERIMENTAL_BUNDLER | |||
There was a problem hiding this comment.
We now share assets between workers, so this is an improvement over the prior bundler.
…parcel-bundler/parcel into more-experimental-bundler-fixes
wbinnssmith
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Merging the latest series of fixes made to the experimental bundler.
🚨 Test instructions
More integration tests pass 🤷
PARCEL_TEST_EXPERIMENTAL_BUNDLER=1 yarn test:integration test/scope-hoisting.js5 failing vs 13 failing on v2
PARCEL_TEST_EXPERIMENTAL_BUNDLER=1 yarn test:integration test/javascript.js25 failing vs 31 failing on v2
✔️ PR Todo