-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loading index.html in dev server when packager/optimizer changes bundle type #7527
Conversation
|
cc8ba78
to
714ba66
Compare
return `/${relativePath(this.options.distDir, p, false)}`; | ||
}); | ||
let htmlBundleFilePaths = this.bundleGraph | ||
.getBundles() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getBundles
excludes inline bundles by default
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
Packagers and optimizers can return a type, which overrides the bundle type. However, this was not correctly exposed by
PackagedBundle
which still returned the old type. That prevented the dev server from finding index.html for example.