Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: support href attribute in <image /> in collecting dependencies in HTMLTransformer #7482

Merged
merged 2 commits into from
Dec 25, 2021
Merged

Feature: support href attribute in <image /> in collecting dependencies in HTMLTransformer #7482

merged 2 commits into from
Dec 25, 2021

Conversation

Shinyaigeek
Copy link
Contributor

@Shinyaigeek Shinyaigeek commented Dec 25, 2021 •
edited
Loading

↪️ Pull Request

Rel: #7479 (fix?)

Hi team 👋

Currently, HTMLTransformer's collectDependencies cannot detect the image in <image href="" />.
xlink:href attribute in <image /> is supported by HTMLTransformer's collectDependencies, so I think it is reasonable to support also href attribute in <image />.

💻 Examples

<!doctype html>
<html>

<head>
</head>

<body>
  <svg>
    <image href="./100x100.png" />
  </svg>
</body>

</html>

🚨 Test instructions

I added an integration test to check whether or not parcel can detect an image in <Image href="" /> correctly.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@height
Copy link

height bot commented Dec 25, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@mischnic mischnic linked an issue Dec 25, 2021 that may be closed by this pull request
@parcel/transformer-svg and @parcel/transformer-css clashing over CSS inline styles #7479
Closed
@devongovett devongovett merged commit af76afc into parcel-bundler:v2 Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@parcel/transformer-svg and @parcel/transformer-css clashing over CSS inline styles
3 participants
@Shinyaigeek @devongovett @mischnic