Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor string matching into util #7376

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Refactor string matching into util #7376

merged 1 commit into from
Nov 29, 2021

Conversation

devongovett
Copy link
Member

Adds two utils to centralize static string matching logic:

  • match_str matches both string literals and static template literals
  • match_str_or_ident matches a string, static template literal, or an identifier

@height
Copy link

height bot commented Nov 28, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.21s -58.00ms
Cached 380.00ms -11.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/index.96016b08.js 1.59kb +0.00b 953.00ms -64.00ms 🚀
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 954.00ms -63.00ms 🚀
dist/modern/index.6be20f01.js 1.13kb +0.00b 953.00ms -65.00ms 🚀
dist/legacy/index.c1bc86aa.css 94.00b +0.00b 1.26s -63.00ms 🚀
dist/modern/index.57a95cbe.css 94.00b +0.00b 1.26s -63.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 625.00ms -55.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 10.71s -20.00ms
Cached 518.00ms +4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.21m +1.37s
Cached 1.74s +64.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/heading4.094fd60f.js 1.27kb +0.00b 33.92s +12.42s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 7.70s +260.00ms
Cached 409.00ms -46.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/Three.js 579.68kb +0.00b 5.57s -467.00ms 🚀

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit bafd9d4 into v2 Nov 29, 2021
@devongovett devongovett deleted the refactor-str branch November 29, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants