Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type generation when tsconfig's "incremental" option is true #7352

Merged

Conversation

astegmaier
Copy link
Contributor

@astegmaier astegmaier commented Nov 23, 2021

↪️ Pull Request

This fixes #7351

The issue is that @parcel/transformer-typescript-types will output blank .d.ts files when the user supplies a tsconfig.json with "incremental": true. The solution is to override this to ensure that we always set it to false before trying to generate types.

It's a follow up to #5346 and tweaks the unit test from that PR to cover both the original case, and this one.

💻 Examples

Examples are in the original bug (#7351).

✔️ PR Todo

  • Added/updated unit tests for this change
  • Included links to related issues/PRs

@height
Copy link

height bot commented Nov 23, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@devongovett devongovett merged commit 9d8df49 into parcel-bundler:v2 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting tsconfig incremental to true causes transformer-typescript-types to output blank .d.ts.file
2 participants