Fix Elm transform showing compiler errors twice #7326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fix for #6703 by wrapping the Exception thrown by
compileToString
in a ThrowableDiagnostic.Unfortunately this doesn't seem to fix #6124.
I looked into using codeframes to get syntax highlighting. Running the elm compiler with
--report=json
gives usable diagnostic location information, but the error message is still quite verbose, including code snippets (again) and hints. It just didn't look right, so I've left it at printing the stack trace.💻 Examples
Before
After
🚨 Test instructions
Start parcel v2 with any broken Elm code, e.g.
Main.elm:
✔️ PR Todo