Fix module augmentation in @parcel/transformers-typescript-types #7315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Edit: This PR is ready for a review - it works to solve the issues below, and includes a unit test to cover this case.
I'd appreciate any feedback - I'm new to this part of parcel, and I want to make sure I don't break anything.
There are two issues that this PR tries to solve, both identified in #7306:
@parcel/transformer-typescript-types
(intentionally) flattens all module declarations, including declarations that are intended to augment an external modules. Then, it will tree-shake things that it finds in the module augmentation, which (most of the time) will result in them being removed. This PR solves the issue by avoiding flattening "nested" module declarations - e.g. module declarations that appear within other module declarations.🚨 Test instructions
See the
"should work with module augmentation"
test inpackages/core/integration-tests/test/ts-types.js
.✔️ PR Todo