Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warning instead of crash if image optimizer fails #7119

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Log warning instead of crash if image optimizer fails #7119

merged 4 commits into from
Oct 26, 2021

Conversation

DeMoorJasper
Copy link
Member

↪️ Pull Request

Partially fixes #7096 by no longer crashing if optimising of image fails.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@height
Copy link

height bot commented Oct 17, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@mischnic
Copy link
Member

cc @surma regarding image copyright/license to include it in the repo

@parcel-benchmark
Copy link

parcel-benchmark commented Oct 17, 2021 •
edited
Loading

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.05s -81.00ms
Cached 298.00ms -10.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 10.64s +172.00ms
Cached 441.00ms -18.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.14m -4.99s 🚀
Cached 1.61s +10.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/pdfRenderer.48c56b00.js 1.11mb +0.00b 52.05s -4.65s 🚀
dist/index.d173b989.js 693.74kb +0.00b 52.01s +10.82s ⚠️
dist/editorView.8daeea01.js 594.83kb +0.00b 51.97s +10.78s ⚠️
dist/popup.64bc9a82.js 209.67kb +0.00b 51.97s +10.78s ⚠️
dist/index.53c272cd.js 145.62kb +0.00b 52.01s +10.82s ⚠️
dist/Toolbar.e3ba4416.js 107.23kb +0.00b 51.97s +10.78s ⚠️
dist/media-viewer.d950776f.js 74.93kb +0.00b 52.05s -4.65s 🚀
dist/card.8ef34b4f.js 62.67kb +0.00b 51.97s +10.78s ⚠️
dist/card.41e5c61a.js 60.71kb +0.00b 52.05s -4.65s 🚀
dist/Modal.cd71eaf3.js 45.33kb +0.00b 51.97s +10.78s ⚠️
dist/js.660b75db.js 17.25kb +0.00b 38.21s -2.97s 🚀
dist/ui.5d3f7adc.js 14.94kb +0.00b 51.97s +10.78s ⚠️
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 51.97s +10.78s ⚠️
dist/dropzone.e0209bf8.js 12.15kb +0.00b 51.97s +10.78s ⚠️
dist/workerHasher.11b8f69d.js 11.83kb +0.00b 38.21s -2.97s 🚀
dist/index.faaa4035.js 6.18kb +0.00b 52.05s -4.65s 🚀
dist/card.26823fa1.js 5.77kb +0.00b 51.97s +10.78s ⚠️
dist/media-viewer.a19e03bf.js 4.50kb +0.00b 38.21s -2.97s 🚀
dist/media-viewer.21624a99.js 3.93kb +0.00b 38.21s -2.97s 🚀
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 51.97s +10.78s ⚠️
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 38.21s -2.97s 🚀
dist/index.c6306681.css 3.47kb +0.00b 52.28s -4.69s 🚀
dist/dropzone.55bef257.js 3.29kb +0.00b 51.97s +10.78s ⚠️
dist/Modal.ecafad9e.js 3.15kb +0.00b 51.97s +10.78s ⚠️
dist/clipboard.df70240c.js 2.93kb +0.00b 51.97s +10.78s ⚠️
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 51.97s +10.78s ⚠️
dist/card.47672f0e.js 2.04kb +0.00b 38.21s -2.97s 🚀
dist/browser.4e039ed7.js 1.69kb +0.00b 51.97s +10.78s ⚠️
dist/workerHasher.14be1ebc.js 1.63kb +0.00b 52.05s -4.65s 🚀
dist/Modal.ca6d4d94.js 1.16kb +0.00b 38.21s -2.97s 🚀
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 51.97s +10.78s ⚠️
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 51.97s +10.78s ⚠️
dist/media-viewer-analytics-error-boundary.c928a889.js 966.00b +0.00b 52.05s -4.65s 🚀
dist/media-card-analytics-error-boundary.30f51dac.js 962.00b +0.00b 51.97s +10.78s ⚠️
dist/media-card-analytics-error-boundary.6e65cc90.js 962.00b +0.00b 52.05s -4.65s 🚀
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 51.97s +10.78s ⚠️
dist/simpleHasher.57fb325c.js 643.00b +0.00b 52.05s -4.65s 🚀
dist/index.html 386.00b +0.00b 52.13s -4.64s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/editorView.88c79e9e.js 594.83kb +0.00b 39.06s -12.29s 🚀
dist/popup.64bc9a82.js 209.67kb +0.00b 39.06s -12.29s 🚀
dist/Toolbar.e3ba4416.js 107.23kb +0.00b 39.06s -12.29s 🚀
dist/Modal.cd71eaf3.js 45.33kb +0.00b 39.06s -12.29s 🚀
dist/js.660b75db.js 17.25kb +0.00b 39.06s -12.29s 🚀
dist/ui.5d3f7adc.js 14.94kb +0.00b 39.06s -12.28s 🚀
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 39.06s -12.29s 🚀
dist/dropzone.e0209bf8.js 12.15kb +0.00b 39.06s -12.29s 🚀
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 39.06s -12.28s 🚀
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 39.06s -12.29s 🚀
dist/dropzone.55bef257.js 3.29kb +0.00b 39.06s -12.29s 🚀
dist/clipboard.df70240c.js 2.93kb +0.00b 39.06s -12.29s 🚀
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 39.06s -12.28s 🚀
dist/browser.4e039ed7.js 1.69kb +0.00b 39.06s -12.29s 🚀
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 39.06s -12.29s 🚀
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 39.06s -12.29s 🚀
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 39.06s -12.28s 🚀

Three.js ✅

Timings

Description Time Difference
Cold 7.22s +123.00ms
Cached 346.00ms -70.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/Three.js 579.68kb +0.00b 5.36s -687.00ms 🚀

Click here to view a detailed benchmark overview.

@surma
Copy link

surma commented Oct 17, 2021

Haha! Yeah, you can use it :)

@devongovett devongovett merged commit da998f7 into v2 Oct 26, 2021
@devongovett devongovett deleted the fix/image-optimizer-warning branch October 26, 2021 19:31
lettertwo added a commit that referenced this pull request Nov 15, 2021
@lettertwo
Merge branch 'v2' into lettertwo/buffer-backed-graph
4f219c8 
* v2: (68 commits)
  Fix RangeError in `not export` error with other file type (#7295)
  Apply sourcemap in @parcel/transformer-typescript-tsc (#7287)
  Fix side effects glob matching (#7288)
  Fix changelog headings
  v2.0.1
  Changelog for v2.0.1
  Resolve GLSL relative to the importer, not the asset (#7263)
  fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248)
  Fixed missing "Parcel" export member in Module "@parcel/core" (#7250)
  Add script to sync engines with core version (#7207)
  Bump swc (#7216)
  Make Webpack loader detection regex dramatically faster (#7226)
  swc optimizer (#7212)
  Update esbuild in optimizer (#7233)
  Properly visit member expressions (#7228)
  Update to prettier 2 (#7209)
  Fix serve mode with target override and target source fields (#7187)
  Update package.json to include the repository (#7184)
  fix #6730: add transformer-raw as dependency of config-webextension (#7193)
  Log warning instead of crash if image optimizer fails (#7119)
  ...
lettertwo added a commit that referenced this pull request Nov 15, 2021
@lettertwo
Merge branch 'v2' into lettertwo/buffer-backed-graph
73cf858 
* v2: (68 commits)
  Fix RangeError in `not export` error with other file type (#7295)
  Apply sourcemap in @parcel/transformer-typescript-tsc (#7287)
  Fix side effects glob matching (#7288)
  Fix changelog headings
  v2.0.1
  Changelog for v2.0.1
  Resolve GLSL relative to the importer, not the asset (#7263)
  fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248)
  Fixed missing "Parcel" export member in Module "@parcel/core" (#7250)
  Add script to sync engines with core version (#7207)
  Bump swc (#7216)
  Make Webpack loader detection regex dramatically faster (#7226)
  swc optimizer (#7212)
  Update esbuild in optimizer (#7233)
  Properly visit member expressions (#7228)
  Update to prettier 2 (#7209)
  Fix serve mode with target override and target source fields (#7187)
  Update package.json to include the repository (#7184)
  fix #6730: add transformer-raw as dependency of config-webextension (#7193)
  Log warning instead of crash if image optimizer fails (#7119)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails during image optimization
5 participants
@DeMoorJasper @mischnic @parcel-benchmark @surma @devongovett