Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semver + import only what is needed #6218

Open
wants to merge 8 commits into
base: v2
Choose a base branch
from

Conversation

aminya
Copy link
Contributor

@aminya aminya commented May 2, 2021

↪️ Pull Request

  • Update semver to 7.3.5
  • Import only what is needed from semver
  • Make parcel and its plugins smaller: reduce the size from ~70KB to ~15KB for each usage

💻 Examples

🚨 Test instructions

The current tests are enough

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@height
Copy link

height bot commented May 2, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@mischnic
Copy link
Member

mischnic commented May 2, 2021

Flow is failing because the individual functions aren't listed in here:

declare module "semver" {

@aminya
Copy link
Contributor Author

aminya commented May 2, 2021

Flow fails again. I am adding it to flow-typed itself here
flow-typed/flow-typed#4073

@aminya
Copy link
Contributor Author

aminya commented May 4, 2021

Unfortunately, Flow doesn't support importing sub-files from a module! This seems like a very large limitation!
flow-typed/flow-typed#4073 (comment)
joarwilk/flowgen#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants