Implement fs searching in rust #5481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
|
devongovett
commented
Dec 15, 2020
Only used by original RPi 2 Model B, backward compatible with armv6, process.arch doesn't distinguish between them
devongovett
commented
Dec 20, 2020
packages/core/utils/src/config.js
Outdated
|
|
||
| return resolveConfig(fs, filepath, filenames, opts); | ||
| ): Promise<?FilePath> { | ||
| // TODO: realpath |
There was a problem hiding this comment.
Unclear about this: it doesn't break any tests at the moment to remove it. However, I think it will change again soon anyway though perhaps slightly different (realpath the result rather than the input). See #5183.
There was a problem hiding this comment.
I believe this will be unnecessary once #5508 is merged since all asset file paths (and therefore where we are searching for config from) will be realpaths. Remove the TODO comment in that PR.
mischnic
reviewed
Dec 29, 2020
mischnic
reviewed
Dec 29, 2020
mischnic
reviewed
Dec 29, 2020
mischnic
reviewed
Dec 29, 2020
mischnic
reviewed
Dec 29, 2020
mischnic
approved these changes
Jan 1, 2021
* Use inputFS.realpathSync get realpath of module * Add test for symlink structure * add symlink file * dynamically create symlinks for test * Update packages/utils/node-resolver-core/src/NodeResolver.js Co-authored-by: Amin Yahyaabadi <[email protected]> * Update NodeResolver.js * Update packages/utils/node-resolver-core/src/NodeResolver.js Co-authored-by: Amin Yahyaabadi <[email protected]> * Update packages/utils/node-resolver-core/src/NodeResolver.js Co-authored-by: Amin Yahyaabadi <[email protected]> * use realpath * Tests use overlayFS * Update packages/utils/node-resolver-core/src/NodeResolver.js Co-authored-by: Amin Yahyaabadi <[email protected]> * Realpath at the end of resolution * Remove realpaths that are now unnecessary * Fix sourcemaps tests * Add tests for symlink resolution * Remove realpath comment * prettier Co-authored-by: dishuostec <[email protected]> Co-authored-by: Niklas Mischkulnig <[email protected]> Co-authored-by: Jasper De Moor <[email protected]> Co-authored-by: Amin Yahyaabadi <[email protected]> Co-authored-by: dishuostec <[email protected]> Co-authored-by: Will Binns-Smith <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new package,
@parcel/fs-search, which implements some very common filesystem searching methods natively in Rust, with a fallback to a JS implementation. These include finding a file by searching up a directory tree, finding a node_modules directory, and checking a number of extensions. Using the native implementation instead of JS is much faster because it avoids crossing the JS -> C++ barrier for every FS call and instead only crosses it once per search.This results in ~15% faster builds overall.
TODO