Feature/#11 windows path issue #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebuilds
approved these changes
Dec 6, 2017
|
We'll need to do this in many more places. The tests are all using posix paths |
pke
reviewed
Dec 6, 2017
| @@ -3,7 +3,7 @@ const path = require('path'); | |||
|
|
|||
| const existsCache = new Map; | |||
|
|
|||
| async function resolve(filepath, filenames, root = '/') { | |||
| async function resolve(filepath, filenames, root = path.parse(filepath).root) { | |||
There was a problem hiding this comment.
On windows you don't get this \ or \\ or / it depends on your volume C:\\
There was a problem hiding this comment.
There was a problem hiding this comment.
Good catch! Will you also fix the tests?
There was a problem hiding this comment.
Tests are hard to fix because I want to know whether it works on linux. I will wait for #35
|
Thanks, I'll get this released shortly. Want to check other places that might need to change too, @StarpTech? |
Closed
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
padmaia
pushed a commit
that referenced
this pull request
Jun 5, 2020
Use exact version of @parcel/source-map of 2.0.0-alpha.4.9 Approved-by: Maia Teegarden
gorakong
pushed a commit
that referenced
this pull request
May 5, 2022
Merge v2 2021-06-28 Approved-by: Joey Slater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.