-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cross-spawn
to perform autoinstall
#374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon93s
changed the title
Use cross-spawn to perform autoinstall
Use Dec 22, 2017
cross-spawn
to perform autoinstall
Well.. it fixed the |
brandon93s
force-pushed
the
cross-spawn
branch
2 times, most recently
from
December 22, 2017 04:13
5c59719
to
109c12b
Compare
brandon93s
force-pushed
the
cross-spawn
branch
from
December 22, 2017 04:13
109c12b
to
bc90871
Compare
Commented out the |
devongovett
approved these changes
Dec 22, 2017
This entire idea of automatically installing dependencies is a very risky
decision that may bite us hard in the future.
It's good to make things convenient, but coddling the programmer probably
isn't necessary. And the yarn/npm checks are just one reason why it's too
complex.
If someone wants to make another package manager, similar to yarn, how
would they even tell parcel how to use it? They can't. So we'd have to add
support for that or just not support that case at all.
Best leave it up to users.
I'm a fan of removing code. The smaller the codebase, the more effective it
usually is. But I know people have strong feelings about this so it's up to
everyone else.
It's just an experience thing. I used to try to get fancy with my programs
like this too, but ornament ends up causing problems.
Ditto for the emojis,by the way. Webstorm can automatically create
hyperlinks from error stack traces printed to the Webstorm console log,
meaning you can just click on the stack trace to be taken exactly to that
point in your codebase. It's incredibly handy and very fast for debugging.
But guess what, it doesn't work for Parcel because we decided normal error
reporting wasn't good enough and tried to make it super fancy and super
emojified, and webstorm has no idea how to interpret that.
And long error messages get cut off.
And all of these concerns simply vanish if we don't try to get fancy. :)
…On Thu, Dec 21, 2017 at 10:30 PM, Devon Govett ***@***.***> wrote:
Merged #374 <#374>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#374 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADo8KPPAv76DqNr-pn2msBViZxZtiPOks5tCzBKgaJpZM4RKmFQ>
.
|
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cross-spawn to spawn process.