Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open the specified host #2763

Merged
merged 2 commits into from
Mar 11, 2019
Merged

Open the specified host #2763

merged 2 commits into from
Mar 11, 2019

Conversation

ofk
Copy link
Contributor

@ofk ofk commented Mar 11, 2019

↪️ Pull Request

Fixed #2725

💻 Examples

Run parcel serve index.html --host 0.0.0.0 --open and http://localhost:1234/ is opened.

🚨 Test instructions

Run the parcel serve command given the host option and the open option (ex. parcel serve index.html --host 0.0.0.0 --open ), opens the host specified by the browser (ex. http://localhost:1234/ ).

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@devongovett devongovett merged commit 70f1008 into parcel-bundler:master Mar 11, 2019
@ofk ofk deleted the fix-2725 branch March 11, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants