Fix and reenable windows scope-hoisting tests #2537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
The scopehoisting test on Windows were disabled because the
afterEach
test hook deleting thedist
folder failed with a permissions error.This was because
JSConcatPackager.end()
didn't callsuper.end()
to close the file handle (no issues on macOS / Linux).I also wrapped the call to
concat
and everything thereafter in a try-catch, becauselet {code: output} = concat(this, ast);
can throw because of e.g. a missing import, meaningsuper.end()
would never be called.💻 Examples
🚨 Test instructions
✔️ PR Todo