Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve package.browser in subfolders (with backslashes) #2445

Merged
merged 8 commits into from
Dec 24, 2018
Merged

Resolve package.browser in subfolders (with backslashes) #2445

merged 8 commits into from
Dec 24, 2018

Conversation

danmarshall
Copy link
Contributor

@danmarshall danmarshall commented Dec 21, 2018 •
edited
Loading

↪️ Pull Request

Fixes #1883

A file path in a subfolder on Windows may contain backslashes, which will not match aliases in the browser field of package.json.

@danmarshall danmarshall mentioned this pull request Dec 21, 2018
Closed
@danmarshall danmarshall changed the title add alias lookup when filename contains backslashes Resolve package.browser in subfolders (with backslashes Dec 21, 2018
@danmarshall danmarshall changed the title Resolve package.browser in subfolders (with backslashes Resolve package.browser in subfolders (with backslashes) Dec 21, 2018
@danmarshall
Copy link
Contributor Author

Aw shucks, it's mostly good:
image

Not sure why it failed, other than this:

WARNING: Scope hoisting tests are disabled on windows due to filesystem errors.

DeMoorJasper
DeMoorJasper previously approved these changes Dec 23, 2018
View reviewed changes
Copy link
Member

@DeMoorJasper DeMoorJasper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the tests are failing, it's probably an anomaly. Looks good though, unfortunately I can't merge things that have failing tests.

Luckily we have recently fixed the CI to show details about the failing tests

@danmarshall
Copy link
Contributor Author

danmarshall commented Dec 24, 2018 •
edited
Loading

@DeMoorJasper @devongovett thanks for the reviews. I added one more commit in hopes that it would trigger a new CI build. By adding a commit, GitHub states that I "dismissed" your review .🤔

@danmarshall
Copy link
Contributor Author

Woohoo! it passed 🥇

@DeMoorJasper DeMoorJasper merged commit 0fac29e into parcel-bundler:master Dec 24, 2018
@mischnic mischnic mentioned this pull request Jan 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett left review comments

@DeMoorJasper DeMoorJasper DeMoorJasper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danmarshall @devongovett @DeMoorJasper