Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This fixes an issue where functions weren't getting treeshaken if two or more function were exported.
This doesn't seem to have a big effect on larger apps.
Closes #2414, closes #2297
🔦 Context
Before
treeshake()
runs in the concat packager, this is the generated asset javascript:After treeshaking: (neither
add
norsub
are actually used!)Notice how
($RK1r$exports.add = $RK1r$export$add), ($RK1r$exports.sub = $RK1r$export$sub);
prevented thesub
function from being removed.That line was introduced by running terser in JSAsset:
becomes:
That comma expression isn't getting handled properly by the treeshaker.
This is why bundling with
--no-minify
behaved correctly: terser didn't run and the assignments are multiple expressions.✔️ PR Todo