Log dev server access for log level verbose or more #2402

lustoykov · 2018-12-12T20:11:02Z

Attempts to address #2390

Failing tests

Error: Cannot find module '@parcel/Logger'

any idea how to import that properly so that CI works? It's fine locally.

lustoykov · 2018-12-13T12:52:10Z

packages/core/parcel-bundler/test/server.js

@@ -1,9 +1,11 @@
 const assert = require('assert');
 const path = require('path');
 const fs = require('@parcel/fs');
+const logger = require('@parcel/Logger');


any guidance on how to import that properly? Seems to work locally, but not in CI.

You have a typo it's lowercase l, '@parcel/logger'

DeMoorJasper · 2018-12-13T13:12:33Z

packages/core/parcel-bundler/src/Server.js

+      const protocol = req.connection.encrypted ? 'https' : 'http';
+      const fullUrl = `${protocol}://${req.headers.host}${req.url}`;
+
+      logger.verbose(fullUrl);


Probably a good idea to add some more info here, besides from just a url, something like Request: <url>

lustoykov · 2018-12-13T16:37:19Z

Thanks for the input! I think we're getting there 😆

CI fails with one last error, but I'm clueless about it, see screenshot

Also, here's a screenshot of the final solution

On a side note: If full test suite is ran, I've noticed the test 1) should auto install babel plugins in javascript.js (besides some others vue-related) fails and this might be due to faulty .babelrc configuration left from a possible migration Babel 6 -> Babel 7.

I think in Babel 7 the non-root babel-plugin-autoinstall/.babelrc is being ignored since not explicitly specified otherwise. Therefore @babel/plugin-proposal-class-properties is never being installed and the assertion fails. The other problem is that even if .babelrc is explicitly specified, test is fine only on first run where @babel/plugin-proposal-class-properties is actually installed and package.json modified respectively. However, in the test itself package.json is reverted to its previous state. In the next run, babel sees that @babel/plugin-proposal-class-properties is in node_modules and doesn't bother to modify package.json and the assertion fails again.

devongovett

Thanks for your contribution!

lustoykov force-pushed the log-server-access-for-verbose branch from 108a4e0 to 6cf6524 Compare December 12, 2018 20:21

lustoykov commented Dec 13, 2018

View reviewed changes

DeMoorJasper reviewed Dec 13, 2018

View reviewed changes

lustoykov force-pushed the log-server-access-for-verbose branch from 6cf6524 to e44e845 Compare December 13, 2018 15:12

devongovett previously approved these changes Dec 17, 2018

View reviewed changes

devongovett dismissed their stale review via 4021245 December 17, 2018 04:25

Log dev server access for log level verbose or more

6aa3334

devongovett force-pushed the log-server-access-for-verbose branch from 4021245 to 6aa3334 Compare December 17, 2018 04:26

devongovett merged commit 84f2894 into parcel-bundler:master Dec 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Log dev server access for log level verbose or more #2402

Log dev server access for log level verbose or more #2402

lustoykov commented Dec 12, 2018 •

edited

Loading

lustoykov Dec 13, 2018

DeMoorJasper Dec 13, 2018

DeMoorJasper Dec 13, 2018

lustoykov commented Dec 13, 2018 •

edited

Loading

devongovett left a comment

Log dev server access for log level verbose or more #2402

Log dev server access for log level verbose or more #2402

Conversation

lustoykov commented Dec 12, 2018 • edited Loading

lustoykov Dec 13, 2018

Choose a reason for hiding this comment

DeMoorJasper Dec 13, 2018

Choose a reason for hiding this comment

DeMoorJasper Dec 13, 2018

Choose a reason for hiding this comment

lustoykov commented Dec 13, 2018 • edited Loading

devongovett left a comment

Choose a reason for hiding this comment

lustoykov commented Dec 12, 2018 •

edited

Loading

lustoykov commented Dec 13, 2018 •

edited

Loading