Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process array of assets for JSON-LD #2319

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Process array of assets for JSON-LD #2319

merged 1 commit into from
Dec 18, 2018

Conversation

dlackty
Copy link
Contributor

@dlackty dlackty commented Nov 24, 2018

↪️ Pull Request

This pull request implemented processing of multiple assets in JSON-LD.

💻 Examples

Before this PR, JSON-LD like below wouldn't get processed correctly, which image array would get ignored:

<script type="application/ld+json">
{
  "@context": "http://schema.org",
  "@type": "LocalBusiness",
  "description": "This is your business description.",
  "name": "Parcel's parcel",
  "telephone": "555-111-2345",
  "openingHours": "Mo,Tu,We,Th,Fr 09:00-17:00",
  "logo": {
      "@type": "ImageObject",
      "url": "images/logo.png",
      "width": 180,
      "height": 120
    },
  "image": ["images/image.jpeg", "images/image.jpeg"]
}
</script>

🚨 Test instructions

Please just check updated test case.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@devongovett
Copy link
Member

This looks good, thanks! Could you add a test?

@dlackty
Copy link
Contributor Author

dlackty commented Dec 11, 2018

@devongovett Sorry that I didn't see the comment, and I'll add a test later tonight!

devongovett
devongovett previously approved these changes Dec 18, 2018
@devongovett devongovett merged commit 3e1c5a3 into parcel-bundler:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants