Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Treat webmanifest as an entry module #2254

Merged
merged 4 commits into from
Nov 8, 2018
Merged

fix: Treat webmanifest as an entry module #2254

merged 4 commits into from
Nov 8, 2018

Conversation

AndreasPizsa
Copy link
Contributor

treat webmanifest as an entry module so it doesn't get content hashed

closes #1466

↪️ Pull Request

Hashing the Webmanifest filename breaks PWA updates.
This PR makes webmanifest an entry module by default so it doesn't get content hashed.

💻 Examples

Bad:

<html>
<head>
    <link rel="manifest" href="manifest.abcdef.webmanifest"> <!-- breaks auto update when hash changes -->
</head>
</html>

Good:

<html>
<head>
    <link rel="manifest" href="manifest.webmanifest"> <!-- keeps auto update intact -->
</head>
</html>

🚨 Test instructions

Unit test included

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@AndreasPizsa
fix: treat webmanifest as an entry module
e667c72 
treat webmanifest as an entry module so it doesn't get content hashed

closes parcel-bundler#1466
@AndreasPizsa
Copy link
Contributor Author

Checks fail because of what look like unrelated issues to me, e.g.

2018-11-05T20:23:08.6972366Z   1) WorkerFarm
2018-11-05T20:23:08.6972641Z        Should start up workers:
2018-11-05T20:23:08.6972944Z      Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/vsts/work/1/s/packages/core/workers/test/workerfarm.js)
2018-11-05T20:23:08.6973212Z       at process._tickCallback (internal/process/next_tick.js:109:7)

I'll happily fix if those if they are related, can you please have a look @devongovett ?

@DeMoorJasper
Copy link
Member

@AndreasPizsa increasing the timeout of mocha in the workers package should resolve that

Sent with GitHawk

@AndreasPizsa
Copy link
Contributor Author

AndreasPizsa commented Nov 6, 2018 •
edited
Loading

So this is now failing because of an Azure Devops server error. Reminds me of how much I love Travis :)

I tried to re-run the build on Azure Devops, but it seems like I can't do that without pushing a new commit (maybe because of a lack of permissions?)

Any ideas how we can unblock this PR @DeMoorJasper ? Thanks!

@devongovett
Copy link
Member

I've triggered a re-run.

@AndreasPizsa
Copy link
Contributor Author

Can you please re-trigger again @devongovett? Thanks!

@DeMoorJasper
Copy link
Member

@AndreasPizsa I've re-triggered the tests

@devongovett devongovett merged commit d8ddcaf into parcel-bundler:master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeMoorJasper DeMoorJasper DeMoorJasper left review comments

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webmanifest name mangling breaks PWA updates
3 participants
@AndreasPizsa @DeMoorJasper @devongovett