Merge fs-watcher-child into Parcel's monorepo #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
reviewed
Oct 25, 2018
| "name": "babel-plugin-autoinstall", | ||
| "devDependencies": { | ||
| "@babel/core": "^7.1.2" | ||
| } |
There was a problem hiding this comment.
this change shouldn't be committed, it's part of the test to verify that it was added.
There was a problem hiding this comment.
Ow damn, I'll remove it and add it to a gitignore to prevent this in the future
devongovett
reviewed
Oct 26, 2018
| this.startchild(); | ||
| } | ||
|
|
||
| startchild() { |
There was a problem hiding this comment.
wonder if it would be worth it to run this inside the existing parcel worker farm at some point. may be worth experimenting with?
There was a problem hiding this comment.
Yeah probably a good idea
devongovett
approved these changes
Oct 26, 2018
devongovett
reviewed
Oct 26, 2018
| ? require('./lib/promisify') | ||
| : require('./src/promisify'); | ||
|
|
||
| exports.errorUtils = |
There was a problem hiding this comment.
heh, we should try to find a way to make this easier if there are going to be a lot of utils 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This adds https://github.com/DeMoorJasper/fswatcher-child to the parcel monorepo, once this gets published
fswatcher-childwill become deprecated.💻 Examples
🚨 Test instructions
✔️ PR Todo