Extract Logger into its own package

[webtaculars]

↪️ Pull Request

Extract logger code into a separate package inside the monorepo

closes [#2134]

💻 Examples

🚨 Test instructions

✔️ PR Todo

• Added/updated unit tests for this change
• Filled out test instructions (In case there aren't any unit tests)
• Included links to related issues/PRs

[devongovett]

should be lower case: @parcel/logger

[devongovett]

this shouldn't change - part of the test is asserting that this is added.

[devongovett]

Awesome, thanks! Can you rebase with master?

[devongovett]

I removed the original emoji and prettyError files from utils and exposed them as part of the @parcel/logger package instead.

[interglobalmedia]

I have parcel-bundler 1.11.0 installed locally (don't want to install globally) and using npx as a result. Everything was fine in development, but can't build my assets for production. Am getting the following in Terminal console:

npm run build                                                      ⏎ ✖ ✹

> [email protected] build /Users/mariacam/Development/html5-drag-and-drop
> npx parcel build index.js -d dist

⚠️  Cannot find module 'parcel-bundler/src/Logger'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:603:15)
    at Function.Module._load (internal/modules/cjs/loader.js:529:25)
    at Module.require (internal/modules/cjs/loader.js:658:17)
    at require (/Users/mariacam/Development/html5-drag-and-drop/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (/Users/mariacam/Development/html5-drag-and-drop/node_modules/parcel-plugin-eslint/index.js:1:78)
    at Module._compile (/Users/mariacam/Development/html5-drag-and-drop/node_modules/v8-compile-cache/v8-compile-cache.js:178:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:733:10)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)
🚨  No entries found.
    at Bundler.bundle (/Users/mariacam/Development/html5-drag-and-drop/node_modules/parcel-bundler/src/Bundler.js:261:17)

Does parcel-bundler not work with npx???

[DeMoorJasper]

@interglobalmedia are you using any plugins?

[interglobalmedia]

I have since removed parcel, but yes I was. If I remember correctly, the parcel-plugin-bundle-manifest, parcel-plugin-eslint, and parcel-plugin-static-files-copy.

[DeMoorJasper]

@interglobalmedia then it’s definitely a plugin issue. Plugins shouldn’t be using internal parcel code (including the logger)

_{Sent with GitHawk}

[interglobalmedia]

I'm not very familiar with parcel. What does that mean? And then why are there plugins to extend parcel? Thanks!

[DeMoorJasper]

It means that parcel/src/Logger shouldn’t be imported directly but by using Bundler.logger instead as internal code is not protected by semver

The plugin architecture wasn’t perfect in parcel 1. It should be easier to extend functionality once Parcel 2 gets released.

The bug originates from this line probably https://github.com/BoltDoggy/parcel-plugin-eslint/blob/7a0947bdec7d4552a68ce3a3bbcba339040a2db2/index.js#L1

[interglobalmedia]

Thanks for the response! I looked for some kind of explanation about plugins in the docs, but didn't really find anything that might help. Just a list. Willing to give Parcel another go when version 2 comes out. But will hold off for the moment. I have things I need in my builds which don't work yet with Parcel 1+ (1.11.1). Looking forward to the release!