Don't modify script nodes with text/html type #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Knockout.js uses <script type="text/html> for named templates. Currently, the type attribute is stripped by parcel. This change prevents that from happening.
devongovett
reviewed
Aug 24, 2018
| @@ -64,7 +64,8 @@ const META = { | |||
| const SCRIPT_TYPES = { | |||
| 'application/javascript': 'js', | |||
| 'text/javascript': 'js', | |||
| 'application/json': false | |||
| 'application/json': false, | |||
| 'text/html': false | |||
There was a problem hiding this comment.
Maybe we should change it to a whitelist instead of a blacklist? Basically, just application/javascript and text/javascript, or if the type attribute is not specified. We could also enable typescript, coffeescript, etc.
There was a problem hiding this comment.
That makes sense. In the case of no type attribute you would like to keep existing behavior and default to JS? Wondering if this will be a breaking change for existing users.
6 tasks
devongovett
approved these changes
Sep 22, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Knockout.js uses <script type="text/html> for named templates. Currently, the type attribute is stripped by parcel. This change prevents that from happening.
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Knockout.js uses <script type="text/html> for named templates. Currently, the type attribute is stripped by parcel. This change prevents that from happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knockout.js uses <script type="text/html> for named templates. Currently, the type attribute is stripped by parcel. This change prevents that from happening.