Fix error logging when thrown errors are strings #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeMoorJasper
changed the title
fathyb
approved these changes
Jul 21, 2018
fathyb
suggested changes
Jul 21, 2018
| error[key] = json[key]; | ||
| }); | ||
| return error; | ||
| } |
There was a problem hiding this comment.
Shouldn't we return something like new Error('Unknown error'), or do it in errorToJson?
There was a problem hiding this comment.
I'm not even sure why it would ever throw something else than an Error object.
I guess I can add a fallback for unknown error
fathyb
approved these changes
Jul 21, 2018
devongovett
approved these changes
Jul 21, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1752