Import existing sourcemaps from libraries #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
requested changes
Jun 24, 2018
src/assets/JSAsset.js
Outdated
|
|
||
| try { | ||
| this.sourceMap = JSON.parse( | ||
| await fs.readFile( |
There was a problem hiding this comment.
what about inline source maps? I think they can be base64 encoded as a data url, so we shouldn't try tp read a file in that case.
There was a problem hiding this comment.
Forgot about those, I'll add support for those as well
devongovett
force-pushed
the
feature/extend-existing-sourcemaps
branch
from
acf5655
to
66e2e4a
Compare
devongovett
approved these changes
Jul 22, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #741