Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache-dir option to cli #1321

Merged
merged 1 commit into from
Jun 24, 2018
Merged

add cache-dir option to cli #1321

merged 1 commit into from
Jun 24, 2018

Conversation

DeMoorJasper
Copy link
Member

Closes #709

@ekoeryanto
Copy link

why it still here?
Please merge it.

@devongovett
Copy link
Member

what if we just call it .parcel-cache always, then it won't overwrite things?

@ekoeryanto
Copy link

@devongovett or ".cache/parcel"

@mohsen1
Copy link
Contributor

mohsen1 commented Jun 19, 2018

cache/parcel will work with existing .gitignore rules

@devongovett devongovett merged commit 12ddda7 into master Jun 24, 2018
@devongovett devongovett deleted the cli-cache-dir branch June 24, 2018 06:16
@devongovett
Copy link
Member

I still think we should change the default so it conflicts less, but I merged anyway because I think it will be important e.g. for CI environments to be able to control the cache dir, for example if you wanted to put it outside a container in a shared location.

If someone wants to make a PR to change the default dir name, that would be great as well!

@devongovett
Copy link
Member

released in v1.9.3.

devongovett pushed a commit that referenced this pull request Oct 15, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants