Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default engines to > 0.25% #1238

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Update default engines to > 0.25% #1238

merged 1 commit into from
Apr 27, 2018

Conversation

devongovett
Copy link
Member

Don’t use “last 2 versions”. See https://jamie.build/last-2-versions.

I think this should be an ok default query, see http://browserl.ist/?q=%3E0.25%25. I don't think we should drop IE 11 by default yet though, so this still means we are always running all plugins in babel-preset-env. A query like > 0.5%, not ie 11, not android 4.4 would reduce that from 24 to 9 plugins... hmm. Thoughts?

cc. @jamiebuilds

@jamiebuilds
Copy link
Member

I sorta think that we should drop IE 11 by default, it's easy enough to turn back on

@devongovett
Copy link
Member Author

ok, WDYT about > 1%, not ie 11: http://browserl.ist/?q=%3E+1%25%2C+not+ie+11. That's 83.98% global coverage compared to 92.6% for the > 0.25% query, and results in just 2 plugins being applied (crazy): babel-plugin-transform-function-name, and babel-plugin-transform-destructuring vs all 24. Even async functions are supported in all of those browsers natively now, awesome. Other than IE11, that drops a bunch of old versions of Chrome, Safari, and Android browser, all with very small usage numbers.

@jamiebuilds
Copy link
Member

hmm i wonder why babel-plugin-transform-function-name is being run

@jamiebuilds
Copy link
Member

Oh, and I'm okay with that as a default. We should definitely document it well though

@devongovett
Copy link
Member Author

Ok, I did this twitter poll and I think there are enough people still targeting IE 11 that we shouldn't remove it by default yet. Even though I'd like to encourage it, I don't really want to deal with the issues that come in from people that don't know why parcel bundles aren't working in IE. Hopefully soon.

@devongovett devongovett merged commit e9b249c into master Apr 27, 2018
@devongovett devongovett deleted the default-engines branch April 27, 2018 14:10
@jamiebuilds
Copy link
Member

heh... wonder how hard/expensive it would be to warn if a bundle is being loaded in a browser that isn't in the browserslist

devongovett added a commit that referenced this pull request Oct 15, 2018
devongovett added a commit that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants