fix: global env problem with node properties morph

src/visitors/globals.js

@@ -24,7 +24,7 @@ module.exports = {
       let key = types.toComputedKey(node);
       if (types.isStringLiteral(key)) {
         let val = types.valueToNode(process.env[key.value]);
-        replace(ancestors[ancestors.length - 2], node, val);
+        morph(node, val);
         delete node.object; // prevent traversing into this node
         asset.isAstDirty = true;
       }
@@ -105,12 +105,12 @@ function matchesPattern(member, match) {
   return true;
 }
 
-// Replaces the key in `parent` whose value is `from` with `to`
-function replace(parent, from, to) {
-  for (let key in parent) {
-    if (parent[key] === from) {
-      parent[key] = to;
-      break;
-    }
+// replace object properties
+function morph(object, newProperties) {
+  for (let key in object) {
+    delete object[key];
+  }
+  for (let key in newProperties) {
+    object[key] = newProperties[key];
   }
 }

test/integration/env/index.js

@@ -1,3 +1 @@
-module.exports = function () {
-  return process.env.NODE_ENV;
-};
+module.exports = (x => x)(process.env.NODE_ENV);

test/javascript.js

@@ -63,10 +63,12 @@ describe('javascript', function() {
     assertBundleTree(b, {
       name: 'index.js',
       assets: ['index.js', 'bundle-loader.js', 'bundle-url.js'],
-      childBundles: [{
-        assets: ['local.js'],
-        childBundles: []
-      }]
+      childBundles: [
+        {
+          assets: ['local.js'],
+          childBundles: []
+        }
+      ]
     });
 
     let output = run(b).default;
@@ -167,7 +169,7 @@ describe('javascript', function() {
     let b = await bundle(__dirname + '/integration/env/index.js');
 
     let output = run(b);
-    assert.equal(output(), 'test');
+    assert.equal(output, 'test');
   });
 
   it('should support adding implicit dependencies', async function() {