Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix box-shadow combination of oklch and currentColor #801

Merged
merged 1 commit into from
Aug 31, 2024
Merged

fix: fix box-shadow combination of oklch and currentColor #801

merged 1 commit into from
Aug 31, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Aug 20, 2024 •
edited
Loading

I'm not entirely sure but looking at the last PR #722, it seems ColorFallbackKind::P3 case's unwrap was not handled.

@devongovett devongovett merged commit 7f59c00 into parcel-bundler:master Aug 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using oklch and currentColor inside box-shadow still fails for certain targets like safari14
2 participants
@hi-ogawa @devongovett