Fix the SFI-reading heuristic for Node v24+#270
Merged
Conversation
gnurizen
approved these changes
May 14, 2026
Collaborator
|
Probably need to fix the failing coredump test, looks like maybe you correctly fixed the line number? But someone added this test w/o adding hello3.js to coredump/testsources/node we should bring that up upstream. |
Collaborator
Author
|
It looks like I'm the one who added that coredump test... unfortunately I didn't save the corresponding hello3.js. |
Collaborator
|
Could try running strings on the coredump and fishing it out! |
Collaborator
Author
|
That's a great idea, and it worked. Here's the source code: The symbolization of the function names is weird, probably some inlining or TCO going on. But indeed the work is going on on line 1, not line 0, so I think the change makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This, along with #269 , contributes to fixing parca-dev/parca-agent#3180 .
It should be clear what is going on from the comments; if not, I can flesh them out.
I think we can close parca-dev/parca-agent#3180 once both of these lands since the behavior is the same as in v20, but since some frames are still symbolized as line "0" in Manoj's test program, I want to investigate those before adding a corresponding test.