Various Lua fixes#248
Merged
Merged
Conversation
gnurizen
reviewed
Apr 12, 2026
gnurizen
reviewed
Apr 12, 2026
gnurizen
reviewed
Apr 12, 2026
gnurizen
reviewed
Apr 12, 2026
| local x = i * i | ||
| end | ||
| ngx.say(debug.traceback()) | ||
| -- ngx.say(debug.traceback()) |
Collaborator
There was a problem hiding this comment.
should probably just delete this
gnurizen
requested changes
Apr 12, 2026
gnurizen
approved these changes
Apr 16, 2026
umanwizard
added a commit
that referenced
this pull request
Apr 28, 2026
The main fixes are as follows: * Document and make clear that hitting the bottom of the Lua stack is an unexpected condition (due to dummy values) * Always return to the native unwinder from a cframe. Previously we didn't do so in the case that it was the root cframe (implicitly relying on the fact that we would then unwind into the dummy values described above on the next iteration, where we would then return to the native unwinder anyway). * Fix the spadjust value for jit frames on aarch64 * Always unwind past the native frame when returning to the native unwinder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main fixes are as follows: