Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create configmap if Fluentbit is enabled #110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nlamirault
Copy link
Contributor

What does this PR change?

Only create configmap for FluentBit when deploy.filebeat.enable: true

Does the PR depend on any other PRs or Issues? If yes, please list them.

Checklist

I confirm, that I have...

@nlamirault nlamirault changed the title [Helm] Create configmap is Fluentbit is enabled Create configmap is Fluentbit is enabled Sep 3, 2024
Signed-off-by: Nicolas Lamirault <[email protected]>
@@ -1,3 +1,4 @@
{{- if .Values.deploy.filebeat.enable }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlamirault filebeat is used to collect audit logs into the system via elasticsearch whereas Fluentbit is used to collect audit logs into the system via a database. Both cannot be used together, why are we trying to control fluentbit's configuration if filebeat is enabled ?

Can you elaborate on the problem and what are we trying to achieve here ?

Copy link
Contributor Author

@nlamirault nlamirault Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was a typo. fixed.
If we set deploy.filebeat.enable: false, this configmap must not be deployed

@nlamirault nlamirault changed the title Create configmap is Fluentbit is enabled Create configmap if Fluentbit is enabled Oct 14, 2024
Signed-off-by: Nicolas Lamirault <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants