Skip to content

Feature/ss58 format#321

Merged
yz89 merged 8 commits intoparallel-finance:masterfrom
alannotnerd:feature/ss58Format
Aug 2, 2021
Merged

Feature/ss58 format#321
yz89 merged 8 commits intoparallel-finance:masterfrom
alannotnerd:feature/ss58Format

Conversation

@alannotnerd
Copy link
Copy Markdown
Contributor

Add system properties for parallel and heiko, but left it default for local test network.

ss58 address format id is registered in paritytech/substrate#9254

@alannotnerd alannotnerd mentioned this pull request Jul 22, 2021
@0x8f701
Copy link
Copy Markdown
Contributor

0x8f701 commented Jul 23, 2021

@alannotnerd hi I think acala has given a good example regarding the token decimals. You can also check here: https://github.com/parallel-finance/parallel/pull/134/files#diff-9a08c969144a056406ced2d9dde2f410e0135639d066f770d14b702ebf909a80
@yz89 do wen need the token decimals ?

@alannotnerd
Copy link
Copy Markdown
Contributor Author

alannotnerd commented Jul 23, 2021

The properties just declare our token's decimals, e.g. PARA.

@yz89 yz89 requested review from kaichaosun and yz89 July 25, 2021 13:39
@alannotnerd
Copy link
Copy Markdown
Contributor Author

@kaichaosun What's your opinion? :p

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #321 (d48db88) into master (3203655) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   70.21%   70.11%   -0.10%     
==========================================
  Files          38       39       +1     
  Lines        2971     2975       +4     
==========================================
  Hits         2086     2086              
- Misses        885      889       +4     
Impacted Files Coverage Δ
node/parallel/src/chain_spec/mod.rs 0.00% <ø> (ø)
primitives/src/lib.rs 0.00% <ø> (ø)
primitives/src/network.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3203655...d48db88. Read the comment docs.

Copy link
Copy Markdown
Contributor

@kaichaosun kaichaosun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more concerns, others are good to be merged.

@yz89 yz89 merged commit 9197c5d into parallel-finance:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants