Feature/ss58 format#321
Feature/ss58 format#321yz89 merged 8 commits intoparallel-finance:masterfrom alannotnerd:feature/ss58Format
Conversation
|
@alannotnerd hi I think acala has given a good example regarding the token decimals. You can also check here: https://github.com/parallel-finance/parallel/pull/134/files#diff-9a08c969144a056406ced2d9dde2f410e0135639d066f770d14b702ebf909a80 |
|
The properties just declare our token's decimals, e.g. PARA. |
|
@kaichaosun What's your opinion? :p |
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 70.21% 70.11% -0.10%
==========================================
Files 38 39 +1
Lines 2971 2975 +4
==========================================
Hits 2086 2086
- Misses 885 889 +4
Continue to review full report at Codecov.
|
kaichaosun
left a comment
There was a problem hiding this comment.
Two more concerns, others are good to be merged.
Add system properties for parallel and heiko, but left it default for local test network.
ss58 address format id is registered in paritytech/substrate#9254