Conversation
0x8f701
force-pushed
the
feat/heiko-runtime
branch
2 times, most recently
from
53146a4 to
665eeca
Compare
0x8f701
requested review from
RainFallsSilent,
ayushmishra2005,
kaichaosun and
yz89
and removed request for
RainFallsSilent
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 69.82% 69.24% -0.58%
==========================================
Files 23 25 +2
Lines 2237 2312 +75
==========================================
+ Hits 1562 1601 +39
- Misses 675 711 +36
Continue to review full report at Codecov.
|
0x8f701
force-pushed
the
feat/heiko-runtime
branch
from
b823740 to
a234da7
Compare
|
@yz89 @kaichaosun shall we merge this? |
|
|
||
| use cumulus_primitives_core::ParaId; | ||
| use parallel_runtime::currency::DOLLARS; | ||
| #[cfg(feature = "runtime-heiko")] |
There was a problem hiding this comment.
I forgot why we have this conditional build feature, is it also used in statemine or polkadot?
There was a problem hiding this comment.
@kaichaosun no actually there are two solutions:
-
build all runtimes while compiling, and then use --chain= to specify different chainspec, the disadvantage of this is: it compiles very slow
-
use feature gate to build only one time
There was a problem hiding this comment.
Can we use a better server to improve the compilation?
Change implementation code to solve build issue doesn't make much sense to me.
| T::PalletId::get().into_account() | ||
| } | ||
|
|
||
| fn ensure_currency(currency_id: &CurrencyId) -> DispatchResult { |
| #[derive(Encode, Decode, Eq, PartialEq, Copy, Clone, RuntimeDebug, PartialOrd, Ord)] | ||
| #[cfg_attr(feature = "std", derive(Serialize, Deserialize, Hash))] | ||
| pub enum CurrencyId { | ||
| DOT("Polkadot", 10), |
There was a problem hiding this comment.
How is the decimal used?
There was a problem hiding this comment.
@kaichaosun it's currently not used, I'd like to do it in next PR. Basically it should replace TOKEN_DECIMAL
There was a problem hiding this comment.
Let's discuss this one in code diff.
Some thoughts from me,
if it's an asset issuance platform, the storage needs to maintain the decimals for a specific asset, frame-assets pallet,
but if it is the native asset for a substrate chain, the source of truth of the decimals locates in chain_spec.json, if we maintain the decimals here, if dot change its decimal, we need to upgrade at the same time, this can be struggle.
0x8f701
force-pushed
the
feat/heiko-runtime
branch
from
a234da7 to
ff64485
Compare
|
@yz89 how should I test it? because it's an obvious thing |
0x8f701
force-pushed
the
feat/heiko-runtime
branch
from
dd6463b to
a73ee55
Compare
0x8f701
force-pushed
the
feat/heiko-runtime
branch
from
a73ee55 to
6b8ac12
Compare
5 participants
close: #74
TODO in next PR: