Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unauthenticated cypher operations in psa-crypto and psa-crypto-sys. #104

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Add unauthenticated cypher operations in psa-crypto and psa-crypto-sys. #104

merged 1 commit into from
Mar 23, 2022

Conversation

egrimley-arm
Copy link
Collaborator

No description provided.

ionut-arm
ionut-arm reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good overall!

psa-crypto/src/operations/cipher.rs Show resolved Hide resolved
psa-crypto/src/operations/cipher.rs Outdated Show resolved Hide resolved
@egrimley-arm egrimley-arm force-pushed the pr-cipher branch 3 times, most recently from d677931 to 3a2f32a Compare March 17, 2022 21:03
ionut-arm
ionut-arm approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

psa-crypto/src/operations/cipher.rs Outdated Show resolved Hide resolved
anta5010
anta5010 approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@anta5010 anta5010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM as far as I understand the code

@ionut-arm ionut-arm merged commit bcff414 into parallaxsecond:main Mar 23, 2022
@egrimley-arm egrimley-arm deleted the pr-cipher branch April 5, 2022 14:45
@ionut-arm ionut-arm mentioned this pull request Apr 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionut-arm ionut-arm ionut-arm approved these changes

@anta5010 anta5010 anta5010 approved these changes

@hug-dev hug-dev Awaiting requested review from hug-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egrimley-arm @anta5010 @ionut-arm