Split between Status and Error #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That allows to only have Error in the Err arm of the Result. Signed-off-by: Hugues de Valon <[email protected]>
Signed-off-by: Hugues de Valon <[email protected]>
ionut-arm
approved these changes
May 19, 2020
Comment on lines
+22
to
+30
| impl Status { | ||
| /// Convert the Status into a Result returning the empty tuple | ||
| pub fn to_result(self) -> Result<()> { | ||
| match self { | ||
| Status::Success => Ok(()), | ||
| Status::Error(error) => Err(error), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not implementing From<Status> for Result?
There was a problem hiding this comment.
I will add it as well! I am keeping both as in some contexts when the compiler can not infer the type it might be more convenient to use ...to_result() rather than Result<()>::from(...)
Signed-off-by: Hugues de Valon <[email protected]>
hug-dev
force-pushed
the
status-codes-split
branch
from
873ffb9
to
5ad5a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also implements conversions between FFI types and Rust native types.