Skip to content

Fix: Context2d font regex too restrictive ( #3904 ) #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Context2d font regex too restrictive ( #3904 ) #3906

wants to merge 2 commits into from

Conversation

Opineppes
Copy link
Contributor

Previously, the regex was not allowing number in font name, now we are allowing number

fixes #3904

HackbrettXXX
HackbrettXXX requested changes Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please add a test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HackbrettXXX HackbrettXXX HackbrettXXX requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Font Awesome 6 Free Solid" not working in 2D context

2 participants

@Opineppes @HackbrettXXX