Skip to content

replace exported enum types by string unions #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2020
Merged

replace exported enum types by string unions #3021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27c15cc
replace exported enum types by string unions
HackbrettXXX Dec 4, 2020
88f2a70
Merge branch 'master' into fix-enum-types
HackbrettXXX Dec 4, 2020
4d211b0
Merge branch 'master' into fix-enum-types
HackbrettXXX Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 13 additions & 19 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,25 +445,19 @@ declare module "jspdf" {
translate(x: number, y: number): void;
}

export enum ImageCompression {
NONE = "NONE",
FAST = "FAST",
MEDIUM = "MEDIUM",
SLOW = "SLOW"
}
export enum ColorSpace {
DEVICE_RGB = "DeviceRGB",
DEVICE_GRAY = "DeviceGray",
DEVICE_CMYK = "DeviceCMYK",
CAL_GRAY = "CalGray",
CAL_RGB = "CalRGB",
LAB = "Lab",
ICC_BASED = "ICCBased",
INDEXED = "Indexed",
PATTERN = "Pattern",
SEPARATION = "Separation",
DEVICE_N = "DeviceN"
}
export type ImageCompression = "NONE" | "FAST" | "MEDIUM" | "SLOW";
export type ColorSpace =
| "DeviceRGB"
| "DeviceGray"
| "DeviceCMYK"
| "CalGray"
| "CalRGB"
| "Lab"
| "ICCBased"
| "Indexed"
| "Pattern"
| "Separation"
| "DeviceN";

export interface ImageOptions {
imageData: string | HTMLImageElement | HTMLCanvasElement | Uint8Array;
Expand Down
3 changes: 2 additions & 1 deletion types/jspdf-tests-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,8 @@ function test_addImage() {
x: 0,
y: 0,
width: 100,
height: 100
height: 100,
compression: "FAST"
});
}

Expand Down
3 changes: 2 additions & 1 deletion types/jspdf-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,8 @@ function test_addImage() {
x: 0,
y: 0,
width: 100,
height: 100
height: 100,
compression: "FAST"
});
}

Expand Down