Update EF-test fixtures to official witness generation pipeline#25
Conversation
|
@jsign @figtracer Can you help with reviewing this? Thanks |
|
|
||
| # We copy the contents of the fixtures/blockchain_tests directory from the specs repo. | ||
| # The Rust test runner uses WalkDir, so preserving the directory structure is important. | ||
| cp -r "$EF_SPECS_DIR/fixtures/blockchain_tests/"* "$FIXTURES_DEST/" |
There was a problem hiding this comment.
this copies fixtures/blockchain_tests/* directly into execution-spec-tests/ so generated fixtures land under execution-spec-tests/for_amsterdam/....
but testing/ef-tests/tests/tests.rs looks for execution-spec-tests/blockchain_tests/for_amsterdam
There was a problem hiding this comment.
Ah, sorry I missed that. The tests passing should have been suspicious.
I left the copy logic as is, but fixed the tests.rs lookup
There was a problem hiding this comment.
@figtracer Sorry for delay, I was handling some personal commitments.
What should I do with failing tests? Debug them in this PR or leave it for another issue?
There was a problem hiding this comment.
i would say that we can leave this for another PR and keep this one as a general ci/fixture improvement
2 participants
This PR transitions the
ef-testssuite to the official witness generation pipeline, replacing legacy static fixtures with theexecution-specsrepository and theuv run filltool.Key Changes:
execution-specstool to dynamically generateexecutionWitnessfields for EEST, zkEVM, and BAL tests.GeneralStateTestsand associated code as they are no longer present in the official fixtures. Also removed runner crate, which relied on old fixtures.ulimit,RUST_MIN_STACK, andRAYON_NUM_THREADS) and forced sequential execution to ensure stability and prevent crashes on macOS.