feat: flatten diag msg with style #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was working on improved lints that would show code diffs, and i realized that despite using
fn highlighted_note, thefn flatten_messageswould remove the style.so this PR aims to enhance
fn flatten_messagesto optionally preserve styles while flattening (depending on whether the emitter supports styles or not).i added a new
fn label_with_style()to try to avoid breaking API changes for solar users, but not sure if may have missed something. @DaniPopes please lmk if the approach looks good or if we should do it differently.PS:
forge-lintPR in case it is useful foundry-rs/foundry#10846