Skip to content

feat: add helper for eth_simulateV1 to TransferInspector#196

Merged
mattsse merged 2 commits into
paradigmxyz:mainfrom
klkvr:klkvr/transfer-insp
Sep 12, 2024
Merged

feat: add helper for eth_simulateV1 to TransferInspector#196
mattsse merged 2 commits into
paradigmxyz:mainfrom
klkvr:klkvr/transfer-insp

Conversation

@klkvr
Copy link
Copy Markdown
Member

@klkvr klkvr commented Sep 12, 2024

ref ethereum/execution-apis#484 paradigmxyz/reth#10829

Also added hook for eofcreate and moved all handling away from _env hooks to ensure correct ordering.

We don't yet insert logs for selfdestructs, would need update on revm side to pass journaled state into the hook

Copy link
Copy Markdown
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse
Copy link
Copy Markdown
Contributor

mattsse commented Sep 12, 2024

clippy unrelated

@mattsse mattsse merged commit 95a25ac into paradigmxyz:main Sep 12, 2024
lwedge99 pushed a commit to sentioxyz/revm-inspectors that referenced this pull request Oct 8, 2024
…yz#196)

ref ethereum/execution-apis#484
paradigmxyz/reth#10829

Also added hook for `eofcreate` and moved all handling away from `_env`
hooks to ensure correct ordering.

We don't yet insert logs for selfdestructs, would need update on revm
side to pass journaled state into the hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants