feat(primitives): k256 crate fallback for secp256k1 module#9989
Merged
feat(primitives): k256 crate fallback for secp256k1 module#9989
k256 crate fallback for secp256k1 module#9989Conversation
mattsse
reviewed
Aug 1, 2024
shekhirin
force-pushed
the
alexey/transaction-util-k256
branch
from
9353f8d to
6e1614f
Compare
mattsse
requested changes
Aug 1, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
needs double check on c-kzg because this obfuscates revm features even more
reth/crates/primitives/Cargo.toml
Line 103 in 0fe93a8
I think this will still get pulled in because we enable c-kzg for primitives somewhere else but still we need to do a proper workspace feature review
shekhirin
changed the title
k256 feature for secp256k1 modulek256 crate fallback for secp256k1 module
mattsse
approved these changes
Aug 1, 2024
Collaborator
|
looks like some rpc code needs changes |
mattsse
approved these changes
Aug 2, 2024
mattsse
approved these changes
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #9478 for
reth-primitivescrate, inspired by #9430The
k256implementation is cross-tested againstsecp256k1.