Conversation
rkrasiuk
added
C-enhancement
Merged
rkrasiuk
added
the
S-blocked
rkrasiuk
force-pushed
the
rkrasiuk/trie-witness
branch
2 times, most recently
from
e2696cc to
cda7023
Compare
rkrasiuk
removed
the
S-blocked
rkrasiuk
force-pushed
the
rkrasiuk/trie-witness
branch
from
cda7023 to
7a9161a
Compare
rkrasiuk
requested review from
Rjected,
gakonst,
mattsse and
rakita
as code owners
mattsse
approved these changes
Jul 30, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
tbh I don't have sufficient context to review this in detail but, logic wise this looks okay to me
| let account = state | ||
| .accounts | ||
| .get(&hashed_address) | ||
| .ok_or(TrieWitnessError::MissingAccount(hashed_address))?; |
Contributor
Author
There was a problem hiding this comment.
just a copy here, is it needed?
| let value = if account.is_some() || storage_multiproof.root != EMPTY_ROOT_HASH { | ||
| account_rlp.clear(); | ||
| TrieAccount::from((account.unwrap_or_default(), storage_multiproof.root)) | ||
| .encode(&mut account_rlp as &mut dyn BufMut); |
Collaborator
There was a problem hiding this comment.
why is this cast required?
Contributor
Author
There was a problem hiding this comment.
to make rust analyzer happy :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref #9249
Create a trie witness implementation that gathers all trie nodes needed to apply state transition.