feat: disable default features in workspace dependencies#9456
feat: disable default features in workspace dependencies#9456jtguibas wants to merge 2 commits intoparadigmxyz:mainfrom
Conversation
jtguibas
force-pushed
the
john/disable-default-features
branch
from
dc2d88f to
db4a543
Compare
| reth-payload-primitives = { path = "crates/payload/primitives" } | ||
| reth-payload-validator = { path = "crates/payload/validator" } | ||
| reth-primitives = { path = "crates/primitives" } | ||
| reth-primitives = { path = "crates/primitives", default-features = false, features = ["std"] } |
There was a problem hiding this comment.
this is a bit dangerous because this now disables "zstd-codec" which is problematic, right @joshieDo ?
so we'd need to enable this somewhere else, I'm thinking on node builder
There was a problem hiding this comment.
IIRC zstd doesn't work on 32-bit architectures btw, so that's why it's not enabled by default.
mattsse
added
the
A-dependencies
|
@mattsse Noticing EF tests failed. Any ideas why compilation flags would effect this? Will do some A/B testing with dependencies and try find source of issue. |
jtguibas
force-pushed
the
john/disable-default-features
branch
from
7592419 to
db4a543
Compare
|
Should be fixed now, seems like an issue with c-kzg not being enabled. |
| reth-prune = { path = "crates/prune/prune" } | ||
| reth-prune-types = { path = "crates/prune/types" } | ||
| reth-revm = { path = "crates/revm" } | ||
| reth-revm = { path = "crates/revm", default-features = false, features = ["std", "c-kzg"] } |
There was a problem hiding this comment.
Are we missing blst feature here?
There was a problem hiding this comment.
yeah this as well
I need to think about all of this a bit, because messing with features like this can result in giga footguns
There was a problem hiding this comment.
Yeah so in the zkVM context, I would ideally like to disable both c-kzg and blst by default. Ideally what would happen here is only std would be enabled.
There was a problem hiding this comment.
Could we just only have features = ["std"] here and then in the crates that need c-kzg/blst we just enable it there?
3 participants
Disables default features in the workspace dependencies.
This is done so that features that do not compile in
wasm32-wasiare not automatically enabled. This change was originally in #9430 but was seperated at the request of @mattsse.