Skip to content

chore: dont enable serde by default for eth-wire #9339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 3 commits into from
Jul 6, 2024
Merged

chore: dont enable serde by default for eth-wire #9339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61e2fe6
chore: dont enable serde by default for eth-wire
mattsse Jul 6, 2024
4ebf5c8
Merge branch 'main' into matt/dont-make-serde-default-for-ethwire
mattsse Jul 6, 2024
720f6d4
fix serde
mattsse Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/net/eth-wire-types/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ proptest-derive.workspace = true
rand.workspace = true

[features]
default = ["serde"]
arbitrary = [
"reth-primitives/arbitrary",
"dep:arbitrary",
Expand Down
4 changes: 2 additions & 2 deletions crates/net/eth-wire-types/src/header.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use alloy_rlp::{Decodable, Encodable};
use bytes::BufMut;
use reth_codecs::derive_arbitrary;
use serde::{Deserialize, Serialize};

/// Represents the direction for a headers request depending on the `reverse` field of the request.
/// > The response must contain a number of block headers, of rising number when reverse is 0,
Expand All @@ -16,7 +15,8 @@ use serde::{Deserialize, Serialize};
///
/// See also <https://github.com/ethereum/devp2p/blob/master/caps/eth.md#getblockheaders-0x03>
#[derive_arbitrary(rlp)]
#[derive(Debug, Copy, Clone, Eq, PartialEq, Hash, Default, Serialize, Deserialize)]
#[derive(Debug, Copy, Clone, Eq, PartialEq, Hash, Default)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub enum HeadersDirection {
/// Falling block number.
Falling,
Expand Down
4 changes: 2 additions & 2 deletions crates/net/eth-wire/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ proptest.workspace = true
proptest-arbitrary-interop.workspace = true
proptest-derive.workspace = true
async-stream.workspace = true
serde.workspace = true

[features]
default = ["serde"]
arbitrary = [
"reth-primitives/arbitrary",
"dep:arbitrary",
]
serde = ["dep:serde"]
serde = ["dep:serde", "reth-eth-wire-types/serde"]

[[test]]
name = "fuzz_roundtrip"
Expand Down